Add better broccoli-side-watch package #2141
Conversation
|
|
||
| ## Usage | ||
|
|
||
| Let's assume you have a v2 addon in the `grand-prix` folder of your top-level folder of your Ember app. |
There was a problem hiding this comment.
this is a bit confusing to me does it intend to say the below?
| Let's assume you have a v2 addon in the `grand-prix` folder of your top-level folder of your Ember app. | |
| Let's assume you have a v2 addon in the `grand-prix` folder of your monorepo that also contains your Ember app. |
There was a problem hiding this comment.
Yeah, probably. I didn't change this, this was coming from the main branch: https://github.com/embroider-build/embroider/blob/main/packages/broccoli-side-watch/README.md. But we can tweak this for sure!
There was a problem hiding this comment.
@void-mAlex updated the Readme, if you want to give it another look!?
|
|
||
| const app = new EmberApp(defaults, { | ||
| trees: { | ||
| app: sideWatch('app', { watching: ['./grand-prix/src'] }), |
There was a problem hiding this comment.
doesn't this imply nesting two package.json?
one for the Ember app and inside of it the v2 addon?
that seems wrong to me
There was a problem hiding this comment.
same here! But yeah, I see what you are meaning. Will go over the Readme once more!
|
This looks ready to go. The beta test failure should be fixed on |
simonihmig
force-pushed
the
side-watch-packages
branch
from
0096f79 to
ff8ad4c
Compare
We have the
broccoli-side-watchon themainbranch only, as such there are only0.0.2-unstable.xxxversions released. That version is only able to watch for explicitly passed folders, which is inconvenient when you want to watch for other packages (addons) in a monorepo, as you need to hard-code (or resolve programatically) the actual folders on disk (/path/to/addon/dist), but what you rather want is an easy way to just list the package names, similar to what ember-auto-import'swatchDependenciesoption does.So this PR is
stablebranchshared-internals, which allows us to get the optimal watched directory given a package name, taking package.json#exports into account (e.g. watching only./distfor common v2 addons, instead of the whole package folder including./src). The plan would be to remove these utils from eai and import frrmshared-internalsonce released.