Commits on Mar 7, 2021

1. Allow macroCondition inside modifier …

   Previously the macro-if transform would already allow to switch between two modifier implementations with a `(if (macroCondition ...) foo bar)` sub-expression inside a modifier. This now also completely removes the modifier if the sub-expression statically evaluates to undefined, allowing you to conditionally apply modifiers. See embroider-build#680 (comment)
   
   Closes embroider-build#680, supersedes embroider-build#692.
   
   Note this only works with Ember 3.25, which now allows you to use a sub-expression as the modifier path, see embroider-build#680 (comment). Older versions would throw a parse error (not exactly sure at which version exactly the changes in the parser where introduced). Therefore I also had to replace the vendored template compiler (for tests) with that of Ember 3.25.

   

   simonihmig committed Mar 7, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e1d0040
   • Browse repository at this point

   Copy the full SHA

   e1d0040 View commit details

   Browse the repository at this point in the history