Ensure errors in webpack.run callback always reject
#838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure all `throws`, including the explicit throw, correctly reject the wrapping promise
rwjblue
approved these changes
Jun 7, 2021
rwjblue
reviewed
Jun 7, 2021
Co-authored-by: Robert Jackson <rjackson@linkedin.com>
stefanpenner
commented
Jun 7, 2021
| if (!stats) { | ||
| // this doesn't really happen, but webpack's types imply that it | ||
| // could, so we just satisfy typescript here | ||
| throw new Error('bug: no stats and no err'); |
There was a problem hiding this comment.
this is what lead me here, but in general try/catch in these async promise resolvers is best practice. Avoiding dropped errors, and breaking the implied contract of the wrapping promise
rwjblue
changed the title
webpack.run callback always reject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all
throws, including the explicit throw, correctly reject the wrapping promise.As far as I can tell, this isn't the root cause of any posted issues, but something I noticed while debugging a different issue.