Allow you to call skip twice with the same name #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a lot of |
ef4
requested changes
Jan 5, 2024
this kind of test is not relevant in a pnpm world
|
@ef4 I got rid of all the yarn 👍 🧶 |
ef4
approved these changes
Jan 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change calling skip twice with the same name would throw an error:
because the first time you called
.skip()it removed it from the list of variants and the second time it would fail. This PR changes it so that it sets a flagskippedso the second time you call.skip()is essentially a no-op and won't fail.This change is to allow you to skip variants globally without needing to also delete any specific skips you have in tests (see this commit for an example)