Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ld-file-upload): add file upload component #861

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

leabarth
Copy link

@leabarth leabarth commented Jul 28, 2023

Description

Fixes #(issue)

Type of change

  • Feature

Is it a breaking change?

  • Yes
  • No

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:52pm

src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated Show resolved Hide resolved
src/liquid/components/ld-file-upload/ld-file-upload.tsx Outdated Show resolved Hide resolved
this.cannotBeChosen = []
this.exceedMaxSize = []
for (let i = 0; i < chosenFiles.length; i++) {
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a Set or a Map here in order to improve performance and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants