Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: init using react-i18next #80

Merged
merged 2 commits into from
May 28, 2017
Merged

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented May 22, 2017

This adds an i18n framework using react-i18next. Using this by:

  1. import { translate } from 'react-i18next';
  2. Wrap the component using translate("category")(...) and use t("name", { ...options }) for texts to be translated.
  3. Add the required translation name in locales/lang/category.json.

@sorpaas
Copy link
Contributor Author

sorpaas commented May 25, 2017

@dulanov How will this PR be dealt with? Seems right now we've got conflicts. Should I push this at a later time or it is possible to start translation now?

@ghost
Copy link

ghost commented May 25, 2017

Always resolve conflicts firstly, @elaineo answer please, is it ok to merge it now?

@elaineo
Copy link
Contributor

elaineo commented May 25, 2017

Ah! Is this a followup to the discussion on slack about adding language support? Everything looks fine to me, but I assume this will be a work in progress, right?

(okay to merge, but we should also open an Issue about adding language support to keep track of progress)

@sorpaas
Copy link
Contributor Author

sorpaas commented May 25, 2017

I've got the framework in. It's working. 😂 So in my opinion it's okay to merge. After that we can gradually replace hard-coded texts with t(...) and add translations.

I'll resolve the conflicts now.

@sorpaas sorpaas mentioned this pull request May 25, 2017
6 tasks
@CLAassistant
Copy link

CLAassistant commented May 25, 2017

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants