Skip to content

Commit

Permalink
Add a hack that fixes #171, and possibly #144 and #167 as well.
Browse files Browse the repository at this point in the history
  • Loading branch information
@emezeske
emezeske committed Jan 20, 2013
1 parent ff55ed9 commit d836402
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion plugin/src/leiningen/cljsbuild.clj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@

(defn- run-local-project [project crossover-path builds requires form]
(leval/eval-in-project (subproject/make-subproject project crossover-path builds)
form
; Without an explicit exit, the in-project subprocess seems to just hang for
; around 30 seconds before exiting. I don't fully understand why...
`(~form (System/exit 0))
requires))

(defn- run-compiler [project {:keys [crossover-path crossovers builds]} build-ids watch?]
Expand Down

3 comments on commit d836402

@rm-hull
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this isn't causing problems when running lein trampoline run - see issue I raised here: technomancy/leiningen#956

@rm-hull
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is still a problem for me, and I've had cause to look into it again recently (a workaround was to not trampoline, but this causes out-of-memory errors on heroku which has a hard 500M limit, and its not enough): browsing and I think the root cause of the hang has been patched in leiningen - technomancy/leiningen@4f2bc32#leiningen-core/src/leiningen/core/eval.clj - just trying to work out how to get the latest lein 2.1.0 snapshot to test this out

@ccfontes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try a working fork that removes the exit hack and therefore allows use of trampoline: [ccfontes/lein-cljsbuild "0.3.2-no-exit"]
Hopefully this hack would be removed from the main repo.

Please sign in to comment.