only reload Clojure source files that define macros (fixes gh-210) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Chas! I'll make sure this goes out in the next release. |
|
Great, thanks! :-D In the meantime, for anyone following along, there's a build of master + the above patch here: |
cemerick
added a commit
that referenced
this pull request
Aug 30, 2013
only reload Clojure source files that define macros (fixes gh-210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reload-clojureonly needs to touch Clojure source files that contain macros (any others cannot affect ClojureScript compilation). Using this heuristic makes it easy for those attempting to provide portable Clojure[Script] APIs to avoid the problem noted in gh-210 by always putting their macros in a separate file/namespace (which is a given when manually crafting a ClojureScript library, but isn't necessarily so when using a tool like cljx or lein-dalap to selectively emit Clojure or ClojureScript code depending on the "target").