Fix #453: use ProcessBuilder for output redirect #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request emezeske#436 removes the call to exit that was added to address emezeske#171. This caused a regression in testing and notify behaviour that was reported as emezeske#453, where subprocesses would hang for 30 seconds after the subprocess completed. This commit avoids the need for pump threads to copy data from subprocess streams by using ProcessBuilder's existing Redirect functionality to either write redirect stream output to files directly, or to inherit System.out and System.err from the main process. This means that `lein test` etc now terminate in a reasonable time again, and avoids the call to `exit` that was causing problems for trampoline tasks.
|
This looks great, thank you! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #436 removes the call to exit that was added to address #171. This
caused a regression in testing and notify behaviour that was reported as #453,
where subprocesses would hang for 30 seconds after the subprocess completed.
This commit avoids the need for pump threads to copy data from subprocess
streams by using ProcessBuilder's existing Redirect functionality to either
write redirect stream output to files directly, or to inherit System.out and
System.err from the main process. This means that
lein testetc now terminatein a reasonable time again, and avoids the call to
exitthat was causingproblems for trampoline tasks.