ProposalResource: remove default str fallback logic (#1772)

* ProposalResource: remove default `str` fallback logic * Tests: fixup: update test expectation --------- Co-authored-by: Russ Garrett <russ@garrett.co.uk>
emfcamp · Sep 1, 2024 · 8911c4e · 8911c4e
1 parent 2d909d2
commit 8911c4e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/api/schedule.py b/apps/api/schedule.py
@@ -56,7 +56,7 @@ def patch(self, proposal_id):
 
         for attribute in ALLOWED_ATTRIBUTES:
             if attribute in payload:
-                setattr(proposal, attribute, payload[attribute] or "")
+                setattr(proposal, attribute, payload[attribute])
 
         db.session.add(proposal)
         db.session.commit()

diff --git a/tests/test_api_proposals.py b/tests/test_api_proposals.py
@@ -83,7 +83,7 @@ def test_clearing_video_url(client, app, db, proposal):
     assert rv.status_code == 200
 
     proposal = Proposal.query.get(proposal.id)
-    assert proposal.youtube_url == ""
+    assert proposal.youtube_url is None
 
 
 def test_rejects_disallowed_attributes(client, app, proposal):