Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hexpansion button chord to also control the LEDs #110

Closed

Conversation

emericklaw
Copy link
Contributor

To prevent duplication of code I moved the LED control inside the event, this might not the the right way of doing things...

Also changed the logic to allow you to use the same chord to remove a hexpansion.

@emericklaw
Copy link
Contributor Author

@MatthewWilkes as the person who created the button chord please can you cast your eye over this. My main concern is how I dealt with moving the LED update code into the event. I am not a python developer, maybe it should be somewhere else!

@MatthewWilkes
Copy link
Member

The light behaviour here is moving into a side effect of string coercion, rather than being a scheduled call, so it won't work (reliably).

It feels like these are independent features, to change the behaviour of the insertion event and to light the LEDs.

Do we know if the behaviour change is desirable? The current choice was just what was easy to do on-site, to be honest.

@MatthewWilkes
Copy link
Member

The latest firmware fixes hexpansion detection, so I think the best option is to remove the chord entirely. Thank you for putting the effort in to help this improve, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants