Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-glow fails cargo check --all-features #2286

Closed
coderedart opened this issue Nov 11, 2022 · 0 comments · Fixed by #3909
Closed

egui-glow fails cargo check --all-features #2286

coderedart opened this issue Nov 11, 2022 · 0 comments · Fixed by #3909
Labels
bug Something is broken

Comments

@coderedart
Copy link
Contributor

coderedart commented Nov 11, 2022

When i tried to run ./sh/check.sh, it fails at the step cargo check --all-features for the egui_glow crate.

apparently, winit requires one of x11 or wayland features to be enabled. because the default-features is false for the egui-winit dep in egui_glow for a long long time. so, its either a recent winit change or nobody ever checked egui_glow crate on linux until now.

To Reproduce
Steps to reproduce the behavior:

  1. Go to crates/egui_glow
  2. run cargo check --all-features

Output

Checking winit v0.27.2
error: Please select a feature to build for unix: `x11`, `wayland`
  --> /home/red/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.2/src/platform_impl/linux/mod.rs:10:1
   |
10 | compile_error!("Please select a feature to build for unix: `x11`, `wayland`");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   Compiling wayland-scanner v0.29.4
error[E0392]: parameter `T` is never used
  --> /home/red/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.27.2/src/event_loop.rs:35:22
   |
35 | pub struct EventLoop<T: 'static> {
   |                      ^ unused parameter
   |
   = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData`

error[E0392]: parameter `T` is never used

Desktop (please complete the following information):

  • OS: Arch Linux
@coderedart coderedart added the bug Something is broken label Nov 11, 2022
YgorSouza added a commit to YgorSouza/egui that referenced this issue Jan 28, 2024
emilk pushed a commit that referenced this issue Jan 30, 2024
This allows them to build correctly on Linux by passing one or both of
the features alongside `winit`.

Closes #3492
Closes #2286
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
This allows them to build correctly on Linux by passing one or both of
the features alongside `winit`.

Closes emilk#3492
Closes emilk#2286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
1 participant