Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eframe window position incorrectly restored when saved on a secondary screen #3176

Closed
abey79 opened this issue Jul 25, 2023 · 1 comment · Fixed by #3239
Closed

eframe window position incorrectly restored when saved on a secondary screen #3176

abey79 opened this issue Jul 25, 2023 · 1 comment · Fixed by #3239
Assignees
@emilk
Labels
bug Something is broken
Milestone
0.23.0

Comments

@abey79
Copy link
Collaborator

abey79 commented Jul 25, 2023

Describe the bug

The eframe window position is not correctly restored after successive launches when moved to a secondary screen.

To Reproduce
Steps to reproduce the behavior (I'm using eframe_template as a basic project with state persistance):

  1. run eframe_template (cargo run)
  2. move the window to the secondary screen
  3. close the window
  4. run again (cargo run) --> the window is restored on the primary screen instead of the secondary screen as expected

Screenshots

IMG_3093.mp4

Desktop:

  • OS: macOS Ventura 13.4.1
  • Display layout:
image
@abey79 abey79 added the bug Something is broken label Jul 25, 2023
@emilk emilk added this to the 0.23.0 milestone Aug 10, 2023
@emilk
Copy link
Owner

emilk commented Aug 11, 2023

It seems WindowBuilder::with_position doesn't work with negative values on Mac (secondary monitors often has negative coordinates). Window::set_outer_position seems to maybe work though, at least slightly better.

@emilk emilk self-assigned this Aug 11, 2023
@emilk emilk mentioned this issue Aug 11, 2023
Merged
@abey79 abey79 mentioned this issue Aug 12, 2023
Merged
3 tasks
abey79 added a commit to rerun-io/rerun that referenced this issue Aug 14, 2023
@abey79
Update egui via a [patch] (#2969)
4c20e4b 
### What

Patch egui to `master`. This ~~brings wgpu to 0.17 and~~ addresses
emilk/egui#3176 🚀

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2969) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2969)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fegui-update/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fegui-update/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
bug Something is broken
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

eframe: Better restore Window position on Mac when on secondary monitor emilk/egui
2 participants
@emilk @abey79