Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable_dt is broken #3830

Closed
emilk opened this issue Jan 17, 2024 · 0 comments · Fixed by #3832
Closed

stable_dt is broken #3830

emilk opened this issue Jan 17, 2024 · 0 comments · Fixed by #3832
Labels
bug Something is broken
Milestone
Next Major Release

Comments

@emilk
Copy link
Owner

emilk commented Jan 17, 2024

It seems the multi-viewport work broke stable_dt, making animations in egui bad
@emilk emilk added the bug Something is broken label Jan 17, 2024
@emilk emilk added this to the Next Major Release milestone Jan 17, 2024
@emilk emilk mentioned this issue Jan 17, 2024
Closed
emilk added a commit that referenced this issue Jan 17, 2024
@emilk
Fix stable_dt
8e94a28 
This broke in #3172

Since 0.24.1, `stable_dt` has been fixed at 1/60s, which is a little
bit _too_ stable.

The code issue was the logic for asking "Is this the result of an
immeditate repaint?" was completely broken (always returning false).

* Closes #3830
@emilk emilk mentioned this issue Jan 17, 2024
Merged
emilk added a commit that referenced this issue Jan 17, 2024
@emilk
Fix stable_dt (#3832)
42013cd 
This broke in #3172

Since 0.24.1, `stable_dt` has been fixed at 1/60s, which is a little bit
_too_ stable.

The code issue was the logic for asking "Is this the result of an
immeditate repaint?" was completely broken (always returning false).

* Closes #3830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging a pull request may close this issue.

Fix stable_dt emilk/egui
1 participant
@emilk