Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose winit WindowType (X11 feature) in ViewportBuilder #4150

Closed
psethwick opened this issue Mar 9, 2024 · 0 comments · Fixed by #4175
Closed

Expose winit WindowType (X11 feature) in ViewportBuilder #4150

psethwick opened this issue Mar 9, 2024 · 0 comments · Fixed by #4175

Comments

@psethwick
Copy link
Contributor

psethwick commented Mar 9, 2024 •
edited
Loading

I want to make x11 windows with _NET_WM_WINDOW_TYPE other than the default. Specifically I want to make utitily/dialogs that automatically float in tiling window managers (i3 and the like)

winit already supports this, I think it just needs the bridge built to egui: https://github.com/rust-windowing/winit/blob/master/src/platform/x11.rs#L17

It looks like there are already platform specific options in ViewportBuilder (wayland, macos), so it seems appropriate enough.

I plan to open a PR for this
@psethwick psethwick mentioned this issue Mar 15, 2024
Merged
emilk added a commit that referenced this issue Mar 21, 2024
@psethwick @emilk
Add x11 window type settings to viewport builder (#4175)
2c9c5f0 
Not sure about the api, currently I've mapped the whole XWindowType
enum, but maybe there's something more sensible to do?

* Closes <#4150>

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@psethwick @emilk @hacknus
Add x11 window type settings to viewport builder (emilk#4175)
72406ca 
Not sure about the api, currently I've mapped the whole XWindowType
enum, but maybe there's something more sensible to do?

* Closes <emilk#4150>

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add x11 window type settings to viewport builder psethwick/egui
1 participant
@psethwick