Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to register native texture in eframe #4243

Closed
Chaojimengnan opened this issue Mar 27, 2024 · 0 comments · Fixed by #4246
Closed

Provide a way to register native texture in eframe #4243

Chaojimengnan opened this issue Mar 27, 2024 · 0 comments · Fixed by #4246

Comments

@Chaojimengnan
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I need to do some custom rendering with framebuffer and texture and then display it via eframe, but eframe doesn't provide a way to convert the native texture id to epaint::TextureId.

I've found Painter::register_native_texture but I can't access it through eframe.

Describe the solution you'd like

  1. Pass the &mut Painter to the user to be able to register the native texture
  2. Provide a function that allows the user to register a native texture.

Describe alternatives you've considered

None.

Additional context

None.
@Chaojimengnan Chaojimengnan mentioned this issue Mar 27, 2024
Merged
emilk added a commit that referenced this issue Mar 27, 2024
@Chaojimengnan @emilk
Add register_native_texture in eframe::Frame (#4246)
570e7cf 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes #4243

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@Chaojimengnan @emilk @hacknus
Add register_native_texture in eframe::Frame (emilk#4246)
670ded5 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#4243

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add register_native_texture in eframe::Frame Chaojimengnan/egui
1 participant
@Chaojimengnan