Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_image! macro should take in an expr not a literal #4510

Closed
ThomasAlban opened this issue May 19, 2024 · 0 comments · Fixed by #4521
Closed

include_image! macro should take in an expr not a literal #4510

ThomasAlban opened this issue May 19, 2024 · 0 comments · Fixed by #4521

Comments

@ThomasAlban
Copy link

The include_image! macro, unlike include_bytes!, currently takes in a literal rather than an expr for the file path. This is annoying because it limits what you can do when using the macro inside other macros.
YgorSouza added a commit to YgorSouza/egui that referenced this issue May 21, 2024
@YgorSouza
Make include_image match the same syntax as include_bytes
5ddb6c8 
Close emilk#4510
@YgorSouza YgorSouza mentioned this issue May 21, 2024
Merged
emilk pushed a commit that referenced this issue May 21, 2024
@YgorSouza
include_image! now accepts expressions (#4521)
7035aa4 
Closes #4510
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@YgorSouza @hacknus
include_image! now accepts expressions (emilk#4521)
b916c66 
Closes emilk#4510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include_image! now accepts expressions YgorSouza/egui
1 participant
@ThomasAlban