Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace directories dependency #4884

Closed
valadaptive opened this issue Jul 28, 2024 · 1 comment · Fixed by #4904
Closed

Replace directories dependency #4884

valadaptive opened this issue Jul 28, 2024 · 1 comment · Fixed by #4904
Labels
bug Something is broken
Milestone
Next Major Release

Comments

@valadaptive
Copy link
Contributor

Describe the bug

The maintainer of the directories crate has intentionally added an MPL-licensed dependency and refuses to remove it. While the MPL isn't technically a viral license, it would still be nice to remove it to avoid any potential legal trouble.

A potential candidate is etcetera, but it appears to have different behavior on macOS with regards to the bundle identifier.
@valadaptive valadaptive added the bug Something is broken label Jul 28, 2024
@YgorSouza
Copy link
Contributor

I wonder if eframe shouldn't just copy the part of the code it needs from one of these crates. It's just one folder anyway. Might contribute towards #4481.

@YgorSouza YgorSouza mentioned this issue Aug 2, 2024
Merged
1 task
@emilk emilk added this to the Next Major Release milestone Aug 27, 2024
emilk pushed a commit that referenced this issue Sep 1, 2024
@YgorSouza
Remove the directories dependency (#4904)
edea5a4 
eframe now has its own logic to find the storage_dir to persist the app
when the persistence feature is enabled, instead of using the
directories crate. The directory should be the same as before (verified
with a unit test).

* Closes <#4884>
* [x] I have followed the instructions in the PR template
486c pushed a commit to 486c/egui that referenced this issue Oct 9, 2024
@YgorSouza @486c
Remove the directories dependency (emilk#4904)
0892243 
eframe now has its own logic to find the storage_dir to persist the app
when the persistence feature is enabled, instead of using the
directories crate. The directory should be the same as before (verified
with a unit test).

* Closes <emilk#4884>
* [x] I have followed the instructions in the PR template
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@YgorSouza @hacknus
Remove the directories dependency (emilk#4904)
2eab6db 
eframe now has its own logic to find the storage_dir to persist the app
when the persistence feature is enabled, instead of using the
directories crate. The directory should be the same as before (verified
with a unit test).

* Closes <emilk#4884>
* [x] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging a pull request may close this issue.

Remove the directories dependency YgorSouza/egui
3 participants
@emilk @YgorSouza @valadaptive