Allow aborting an exit event #1038

lampsitter · 2022-01-04T14:00:35Z

This addresses the first point in #814.

I am not sure how to handle the second scenario in the issue as integration is moved into the closure

egui-winit/src/epi.rs

epi/src/lib.rs

emilk

The example and API is very good, but I think the implementation could be made a lot simpler

egui_glow/src/epi_backend.rs

epi/src/lib.rs

emilk · 2022-01-17T17:45:13Z

thanks!

lampsitter commented Jan 4, 2022

View reviewed changes

egui-winit/src/epi.rs Outdated Show resolved Hide resolved

lampsitter force-pushed the exit branch 3 times, most recently from a782a76 to 7b8ba72 Compare January 4, 2022 19:53

lampsitter marked this pull request as ready for review January 4, 2022 19:55

Mingun reviewed Jan 5, 2022

View reviewed changes

epi/src/lib.rs Outdated Show resolved Hide resolved

lampsitter force-pushed the exit branch 7 times, most recently from 770ec68 to 6f73886 Compare January 11, 2022 17:36

emilk requested changes Jan 17, 2022

View reviewed changes

egui_glow/src/epi_backend.rs Outdated Show resolved Hide resolved

epi/src/lib.rs Outdated Show resolved Hide resolved

Allow aborting an exit event

d69c549

lampsitter force-pushed the exit branch from 6f73886 to d69c549 Compare January 17, 2022 14:58

emilk approved these changes Jan 17, 2022

View reviewed changes

emilk merged commit ab77099 into emilk:master Jan 17, 2022

lampsitter deleted the exit branch January 17, 2022 19:17

Provide feedback