Fix bugs in glow on web #1092
Merged
Fix bugs in glow on web #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed this check in #1020 because it produced a warning on Firefox. Better a warning than an OpenGL error though.
The browser will only allow the first thing we check, so this will prevent webgl2 from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1087
Two major bugs!
The first introduced in #888:
We would always get the WebGL1 context from the canvas first, before trying WebGL2. This made later attempts to get the webgl2 context failed (since we already told the browser we were interested in WebGL1).
The second introduced in #1020:
We used to check
WEBGL_debug_renderer_infobefore callinggl.get_parameter(web_sys::WebglDebugRendererInfo::UNMASKED_RENDERER_WEBGL). I removed that check in #1020, making theget_parameterfail with an OpenGL error, which lead to later asserts failing.I've since down-graded these asserts to log instead of crashing.