Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/drag window #1108

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Bugfix/drag window #1108

merged 6 commits into from
Jan 26, 2022

Conversation

a-liashenko
Copy link
Contributor

@a-liashenko a-liashenko commented Jan 14, 2022 •
edited by emilk
Loading

Fix drag_window behavior on Windows.
I've tested my changes only on Windows 10 and Linux Mint OS.

@a-liashenko a-liashenko mentioned this pull request Jan 14, 2022
Closed
emilk
emilk requested changes Jan 17, 2022
View reviewed changes
egui-winit/src/epi.rs Outdated Show resolved Hide resolved
emilk
emilk approved these changes Jan 17, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line to eframe/CHANGELOG.md and egui-winit/CHANGELOG.md. Then LGTM!

@a-liashenko a-liashenko marked this pull request as ready for review January 26, 2022 18:52
emilk
emilk approved these changes Jan 26, 2022
View reviewed changes
egui-winit/src/epi.rs Show resolved Hide resolved
egui-winit/src/epi.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 0d00185 into emilk:master Jan 26, 2022
@emilk
Copy link
Owner

emilk commented Jan 26, 2022

Thank you!

@emilk emilk mentioned this pull request Feb 10, 2022
Closed
@emilk emilk mentioned this pull request Mar 23, 2022
Open
@a-liashenko a-liashenko deleted the bugfix/drag_window branch April 17, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour of drag_window drag_window scuffed even on Windows
2 participants
@a-liashenko @emilk