Take Glow context using Arc. #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows usage with a Glow context that is passed between threads.
|
asny/three-d#248 has been merged, so this is ready. Only thing remaining is to remove the override, once three-d version 0.12 is published. |
surban
changed the title
emilk
reviewed
May 21, 2022
| @@ -12,4 +12,4 @@ publish = false | |||
| eframe = { path = "../../eframe", features = ["glow"] } | |||
| egui_glow = { path = "../../egui_glow" } | |||
| glow = "0.11" | |||
| three-d = { version = "0.11", default-features = false } | |||
| three-d = { version = "0.12", default-features = false } | |||
There was a problem hiding this comment.
I think we should use git = "https://github.com/asny/three-d.git", rev = "7ac4f3e1e14335290e505a5799a0b88717474678" here to make it easier for others to copy-paste this example without getting surprise errors!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows usage with a Glow context that is passed between threads.
This is WIP because it first requires merging of asny/three-d#248.
Closes #1637.