Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(eframe) add Frame.set_visible #1808

Merged
merged 3 commits into from
Jul 21, 2022
Merged

(eframe) add Frame.set_visible #1808

merged 3 commits into from
Jul 21, 2022

Conversation

NotNite
Copy link
Contributor

@NotNite NotNite commented Jul 7, 2022

Closes #1800.

You can use frame.set_visibility(false); to hide the window - good for background applications that open from a hotkey.

@NotNite NotNite marked this pull request as draft July 7, 2022 11:25
@NotNite
Copy link
Contributor Author

NotNite commented Jul 7, 2022

(Still needs support for web.)

@NotNite NotNite marked this pull request as ready for review July 7, 2022 11:43
@rdrpenguin04
Copy link

Is there a reason you chose set_visibility instead of set_visible?

Other than that, I think it looks good, but I'm not a maintainer.

@NotNite
Copy link
Contributor Author

NotNite commented Jul 13, 2022

It's what popped into my head at the time - set_visible probably sounds better. I can change if requested.

@emilk
Copy link
Owner

emilk commented Jul 21, 2022

Looks good, but I agree that set_visible is a better name.

@NotNite
Copy link
Contributor Author

NotNite commented Jul 21, 2022

Renamed it.

@emilk emilk changed the title (eframe) add Frame.set_visibility (eframe) add Frame.set_visible Jul 21, 2022
@emilk emilk merged commit 0338843 into emilk:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to set eframe window visiblity
3 participants