Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make egui_wgpu::RenderPass Send and Sync #1883

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Make egui_wgpu::RenderPass Send and Sync #1883

merged 4 commits into from
Aug 3, 2022

Conversation

leudz
Copy link
Contributor

@leudz leudz commented Aug 3, 2022

I didn't open an issue as this is a tiny change.

I believe RenderPass was supposed to be Send + Sync since the callback has the bounds.
This PR changes the flavor of TypeMap used and make RenderPass Send + Sync.

@leudz leudz marked this pull request as ready for review August 3, 2022 04:28
@emilk
Copy link
Owner

emilk commented Aug 3, 2022

Good catch! We can also add this to ensure this in the future:

#[test]
fn render_pass_impl_send_sync() {
    fn assert_send_sync<T: Send + Sync>() {}
    assert_send_sync::<RenderPass>();
}

@emilk emilk merged commit 1af446b into emilk:master Aug 3, 2022
@leudz
Copy link
Contributor Author

leudz commented Aug 3, 2022

Thanks for merging it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants