Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eframe MacOS: Support fullsize content (no titlebar, but window controls) #2049

Merged
merged 5 commits into from
Sep 16, 2022
Merged

eframe MacOS: Support fullsize content (no titlebar, but window controls) #2049

merged 5 commits into from
Sep 16, 2022

Conversation

paulrouget
Copy link
Contributor 

fullsize_content: false

Screenshot 2022-09-16 at 12 53 59

fullsize_content: true

Screenshot 2022-09-16 at 12 51 58

@emilk
Copy link
Owner

emilk commented Sep 16, 2022

Very cool! I guess it is up to the user to add some space for the close buttons in the top left?

@paulrouget
Copy link
Contributor Author

Very cool! I guess it is up to the user to add some space for the close buttons in the top left?

Yes.

emilk
emilk reviewed Sep 16, 2022
View reviewed changes
crates/eframe/CHANGELOG.md Outdated Show resolved Hide resolved
@emilk emilk merged commit c411706 into emilk:master Sep 16, 2022
@emilk
Copy link
Owner

emilk commented Sep 16, 2022

Thanks!

@emilk emilk changed the title MacOS: Support fullsize content (no titlebar, but window controls) eframe MacOS: Support fullsize content (no titlebar, but window controls) Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulrouget @emilk