wgpu renderer now always requires a RenderPass being passed in, pass command encoder to prepare callback #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also implies that it no longer owns the depth buffer! (why would it anyways!)
Wumpf
changed the title
Wumpf
force-pushed
the
wgpu-always-pass-renderpass
branch
from
55b3d2f
to
5c72043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also implies that it no longer owns the depth buffer! (why would it anyways!)
Closes #2083
Closes most of #2022 - I'd argue there should be a separate ticket for the "move winit integration elsewhere" bit
Closes half of #2084 - we get the command encoder, but haven't gone as far as removing the queue (which I also kinda don't want to right now because where else would one get it from if a
prepareneeds the queue's data uploading functionality 🤔 )cc: @kvark