bump msrv 1.64 and tts + bindgen dep #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindgen
dep usingcargo update -p bindgen
egui_winit
andeframe
cratesubuntu-latest
toubuntu-22.04
This is specifically to fix the
speech-dispatcher
crate compilation issues on platforms likeArch Linux
.We ended up at this PR due to the following series of events:
ubuntu-20.04
which has an old version of library in its repository. but other distros like Arch have the latest version which will fail to link due to breaking ABI changes.speech-dispatcher
crate, we need to updatetts
crate version.speech-dispatcher
crate has some issues withbindgen
version0.60
, so we need to manually bump that to0.61
(latest).bindgen
latest version requires minimum version of rust to be1.64
as it uses thestd::ffi::*
types .Finally,
speech-dispatcher
inubuntu-latest
(20.04 LTS) is version0.9
. our changes won't compile because its too old and that library had breaking changes since then.speech-dispatcher
inubuntu-22.04
(will be default forubuntu-latest
by this month end) is version0.11
and will compile successfully.if we want to stick with
ubuntu-latest
, then this PR will have to wait for December i guess.https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/
Closes #1125
clippy got a few new lints. for now, i added them to allow section of cranky.toml so that i can get this to compile for now.
I could fix those lints, but i am afraid it will touch a lot of files. If its okay to fix those lints, i can create a follow up PR to this.
I wanted to keep the noise low for this PR, so kept the changes as minimal as i could