-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eframe: add set_minimized and set_maximized #2292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, thanks for working on this!
update button text fix clippy
The cranky step should pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this problem caused by this PR? |
Yeah, I looked a bit closer. Apearently asking And there is no winit event for maximize state changing. |
When learning EGUI, I found that when I click the maximize button, the window in Windows will ignore the position of the task bar and directly enter the full screen state In ubuntu, the taskbar can be explicitly displayed normally Under normal circumstances, clicking Maximize should only maximize the window, and should not enter the full screen state! |
Hi @emilk, could you please check if this can be fixed by maintaining the window maximized state in the app? |
Hi @yunfengwangluo, could you show the command you run? I haven't witnessed this behavior. |
It seems |
So the main winit problem was fixed by rust-windowing/winit#2636, but we need to wait for a new winit release, but that's coming pretty soon: |
Another nice thing to implement would be double-clicking the title-bar to maximize. |
* add actions for window controls * add maximized to WindowInfo update button text fix clippy * add overlap icon when maximized * remove argument `app` * remove WindowInfo { maximized } * Update minimum window size * Double-click titlebar to toggle maximized state --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This PR adds some window actions to enable the possibility to create client-side decorations in egui applications.