Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select all text when drag value gets focus #2650

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

lictex
Copy link
Contributor

@lictex lictex commented Jan 30, 2023

currently drag value textboxes reuse the cursor state from the previous focus, which doesnt really make sense imo.

this patch ensures all texts are selected when a drag value is clicked, so user can type directly to overwrite the value.
seems that other common ui toolkits also behave like this.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - thanks!

@emilk emilk merged commit d15f4ef into emilk:master Feb 4, 2023
@lictex lictex deleted the dragvalue_select branch February 5, 2023 09:59
lictex added a commit to lictex/egui that referenced this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants