Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eframe window position bug (pixels vs points) #2763

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Fix eframe window position bug (pixels vs points) #2763

merged 3 commits into from
Feb 28, 2023

Conversation

get200
Copy link
Contributor

@get200 get200 commented Feb 25, 2023

No description provided.

emilk
emilk approved these changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes, thanks! Just one thing that I believe is now slightly wrong

crates/eframe/src/native/epi_integration.rs Outdated Show resolved Hide resolved
@get200 get200 requested a review from emilk February 26, 2023 12:13
emilk
emilk approved these changes Feb 26, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk
Copy link
Owner

emilk commented Feb 26, 2023

You got a cargo cranky issue to fix!

@get200 get200 requested a review from emilk February 27, 2023 15:58
@emilk emilk merged commit 8345847 into emilk:master Feb 28, 2023
mikedilger pushed a commit to mikedilger/egui that referenced this pull request Mar 7, 2023
@get200 @mikedilger
fix window position display error (physical pixels converted to logic… (
2777468 
emilk#2763)
@emilk emilk added bug Something is broken eframe Relates to epi and eframe labels Apr 18, 2023
@emilk emilk changed the title fix window position display error (physical pixels converted to logic… Fix window position bug (pixels vs points) Apr 18, 2023
@emilk emilk changed the title Fix window position bug (pixels vs points) Fix eframe window position bug (pixels vs points) Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
bug Something is broken eframe Relates to epi and eframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@get200 @emilk