eframe: Set app icon on Mac and Windows #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: correctly set window title on Mac when launching from another process, e.g. python. Co-authored-by: Wumpf <andreas@rerun.io>
emilk
force-pushed
the
emilk/set-app-icon
branch
from
9307e38
to
e2ebb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeOptions::icon_datais now fully used on Mac and Windows to set the icon on alt-tab and in the doc/taskbar.Also: correctly set window title on Mac when launching an
eframeapp from another process, e.g. python.Most of the code is by @Wumpf, copied from https://github.com/rerun-io/rerun/blob/0a1d68681c72c9b9e49e5fb1b091425ad96fca32/crates/re_viewer/src/app_icon.rs
Ideally this should be ported to
winitat some point