Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention store in TextEditState doc comment #2988

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

fxdave
Copy link
Contributor

@fxdave fxdave commented May 13, 2023

To me it was confusing because I tried set_cursor_range and it didn't update the cursor range. After that, I found that the output is not a reference, nor a smart pointer, so I thought: "Ok, it might be for some internal use but not external." I didn't pay attention to the store method.
It would be good to have a comment that would have directed me to that method.

Closes #2950

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@emilk emilk added docs and examples Improving and adding documentation and examples egui labels May 22, 2023
@emilk emilk merged commit 13769c2 into emilk:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and examples Improving and adding documentation and examples egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set TextEdit cursor after the render
2 participants