Add an optional app_id field to eframe's NativeOptions for Wayland #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in the window builder to set the application ID, which is e.g. important for a proper configuration in `.desktop` files under Wayland. When no application ID is explicitly set, it defaults to the title of the window.
The wayland feature is not sufficent as constraint and it won't compile e.g. under Windows.
While Wayland could also be used on other Unix-Systems like FreeBSD, this would probably need some specific testing. Winit uses the following definition as "wayland_platform" and on which the required packages are available:
> wayland_platform: { all(feature = "wayland", free_unix, not(wasm), not(redox)) },
The title might be used to also communicate state (opened file, ...) to the user and this might have unforeseen consequences for the application ID. It seems to be better to use the old behavior of not setting an application ID in this case. Also add an example on how to set the application ID in the documentation.
emilk
reviewed
May 22, 2023
emilk
approved these changes
May 22, 2023
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
|
Thanks for the review! I agree with all the proposed (it is already committed), and would also like the idea of using the |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1600.
The new
app_idis used in the window builder to set the Wayland application ID using the winit API, which is e.g. important for a proper configuration in.desktopfiles.There should not be any changes in the behavior for existing applications.
The new field is only available when the
target_osis set to "linux" and the "wayland" feature is enabled (similar to thefullsize_contentfield in macOS). The limitation totarget_os = "linux"is needed because the winit crate does not export the needed trait on Windows and other Non-Unix systems (causing compilation issues otherwise).Because this makes the configuration a little bit more difficult to use, I added an example in its documentation.