Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eframe: Fix docs about web #3026

Merged
merged 1 commit into from
Aug 9, 2023
Merged

eframe: Fix docs about web #3026

merged 1 commit into from
Aug 9, 2023

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented May 25, 2023

In 0.22.0, eframe::start_web has been replaced with eframe::WebRunner.

But, there is a missed document in eframe /lib.rs.

//! call [`crate::run_native`] from your `main.rs`, and/or call `eframe::start_web` from your `lib.rs`.

I think it should be like:

//! call [`crate::run_native`] from your `main.rs`, and/or use `eframe::WebRunner` from your `lib.rs`.

And thanks for driving the artistic Rust GUI framework!

In `0.22.0`,  `eframe::start_web` has been replaced with `eframe::WebRunner`, which also installs a nice panic hook (no need for `console_error_panic_hook`).
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk merged commit 35027d3 into emilk:master Aug 9, 2023
@emilk emilk added the eframe Relates to epi and eframe label Aug 9, 2023
@emilk emilk changed the title Fix a document: eframe::start_web eframe: fix docs for web Aug 9, 2023
Swyter added a commit to eurotools/eurochef that referenced this pull request Aug 18, 2023
@emilk emilk changed the title eframe: fix docs for web eframe: Fix docs for web Sep 27, 2023
@emilk emilk added the docs and examples Improving and adding documentation and examples label Sep 27, 2023
@emilk emilk changed the title eframe: Fix docs for web eframe: Fix docs about web Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and examples Improving and adding documentation and examples eframe Relates to epi and eframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants