Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::borrow::Cow<'_, str> now implements TextBuffer #3164

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

burtonageo
Copy link
Contributor

This allows Cow<'_, str> to be editable in TextEdit widgets. This allows a small optimisation where an immutable value can be provided by default, but then cloned and edited when it is modified using a text edit.

Please let me know if there are any tests or anything else I should add. Thanks for your time.

@emilk emilk added the egui label Aug 9, 2023
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

CHANGELOG.md Outdated Show resolved Hide resolved
@burtonageo
Copy link
Contributor Author

Fixed the missing semicolons

@emilk emilk merged commit 08c46ac into emilk:master Sep 18, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants