Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: framebuffer clear when using glow with multi-viewports #3713

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Bug fix: framebuffer clear when using glow with multi-viewports #3713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/eframe/src/native/glow_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,12 +532,16 @@ impl GlowWinitRunning {
(raw_input, viewport_ui_cb)
};

{
let clear_color = self
.app
.clear_color(&self.integration.egui_ctx.style().visuals);

let has_many_viewports = self.glutin.borrow().viewports.len() > 1;
let clear_before_update = !has_many_viewports; // HACK: for some reason, an early clear doesn't "take" on Mac with multiple viewports.

if clear_before_update {
// clear before we call update, so users can paint between clear-color and egui windows:

let clear_color = self
.app
.clear_color(&self.integration.egui_ctx.style().visuals);
let mut glutin = self.glutin.borrow_mut();
let GlutinWindowContext {
viewports,
Expand Down Expand Up @@ -608,6 +612,10 @@ impl GlowWinitRunning {

let screen_size_in_pixels: [u32; 2] = window.inner_size().into();

if !clear_before_update {
painter.clear(screen_size_in_pixels, clear_color);
}

painter.paint_and_update_textures(
screen_size_in_pixels,
pixels_per_point,
Expand Down
Loading