Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high CPU usage on Windows when app is minimized #3985

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Fix high CPU usage on Windows when app is minimized #3985

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f7b7c28
patch #3982
rustbasic Feb 6, 2024
e044fde
Update run.rs
rustbasic Feb 6, 2024
1db49d6
Update run.rs
rustbasic Feb 6, 2024
19baadd
Update run.rs
rustbasic Feb 6, 2024
9021f89
Update run.rs
rustbasic Feb 6, 2024
ee44024
Update run.rs
rustbasic Feb 6, 2024
04aa82a
Update run.rs
rustbasic Feb 6, 2024
e597126
Update run.rs
rustbasic Feb 6, 2024
883e3ad
Update run.rs
rustbasic Feb 6, 2024
91c2bae
Merge branch 'emilk:master' into patch5
rustbasic Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions crates/eframe/src/native/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,13 @@ fn run_and_return(

if let Some(window) = winit_app.window(*window_id) {
log::trace!("request_redraw for {window_id:?}");
if !window.is_minimized().unwrap_or(false) {
let is_minimized = window.is_minimized().unwrap_or(false);
if is_minimized {
false
} else {
window.request_redraw();
true
}
true
} else {
log::trace!("No window found for {window_id:?}");
false
Expand Down Expand Up @@ -347,10 +350,13 @@ fn run_and_exit(

if let Some(window) = winit_app.window(*window_id) {
log::trace!("request_redraw for {window_id:?}");
if !window.is_minimized().unwrap_or(false) {
let is_minimized = window.is_minimized().unwrap_or(false);
if is_minimized {
false
} else {
window.request_redraw();
true
}
true
} else {
log::trace!("No window found for {window_id:?}");
false
Expand Down
Loading