Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rfd and env_logger #4164

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

oscargus
Copy link
Contributor

Not sure what the policy is, but would be nice to have the latest versions of these as one may expect most programs using egui wanting the latest versions.

@oscargus
Copy link
Contributor Author

oscargus commented Mar 12, 2024

Found #4160, so this should maybe wait until after that? If not, I can remove the image bump from this.

Edit: removed image. Maybe one should do the workspace thing for these as well in the examples?

@oscargus oscargus marked this pull request as draft March 12, 2024 10:49
@oscargus oscargus changed the title Bump image, rfd, env_logger Bump rfd and env_logger Mar 12, 2024
@oscargus
Copy link
Contributor Author

The newest version of rfd has dependencies that require rustc 1.75. Should I bump where required or remove the bump of rfd?

@emilk
Copy link
Owner

emilk commented Mar 29, 2024

There's no explicit policy, but I try to keep the direct dependencies of the published crates reasonably up-to-date.

But rfd and env_logger are only used by examples, so I feel less need to keep those up-to-date. Why not keep them up to date?

  • Sometimes updating adds more 3rd party dependencies and compile time
  • Sometimes updating requires a newer MSRV (as you've noticed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants