Fix InnerSize
command not resizing viewport
#4207
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms changing window size via
request_inner_size
doesn't trigger aResized
event, in this case the viewport is not resized.I'm new to this project and I think that this MR needs work.
What would the correct way to send the return value of
request_inner_size
to the resize function of the glutin surface?egui/crates/egui-winit/src/lib.rs
Line 1314 in 7691996
Would setting
viewport.info.inner_rect
and resizing from that be correct?ViewportCommand::InnerSize
doesn't update the content size #4196