Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For keep the border so we know where TextEdit exists. #4242

Closed
wants to merge 33 commits into from

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Mar 27, 2024

For keep the border so we know where TextEdit exists.

@rustbasic rustbasic changed the title For Keep the border so we know where TextEdit exists. For keep the border so we know where TextEdit exists. Mar 27, 2024
@emilk
Copy link
Owner

emilk commented Mar 30, 2024

Can you show an before-and-after image of the default egui style with this change?

@rustbasic
Copy link
Contributor Author

rustbasic commented Mar 31, 2024

This is the image I posted before.
There is a lrectangle line in the input section at the end.
It would be better to know that TextEdit exists.

By the way, can I use ui.visuals().widgets.noninteractive.bg_Stroke?

Before :

explain20240313-1

After :

explain20240312

@emilk
Copy link
Owner

emilk commented Apr 21, 2024

Seeing screenshots of your heavily customized app is not helpful.

This is what I'm interested in:

Before this PR:
Screenshot 2024-04-21 at 11 59 24

After this PR:
Screenshot 2024-04-21 at 11 58 58

Now I understand what the change is. I can see the benefits (better readability) and the downsides (its uglier)

@rustbasic
Copy link
Contributor Author

Seeing screenshots of your heavily customized app is not helpful.
=> Sorry about that. but, I don't have enough time to even edit images.

There are pros and cons, but I think the advantage of knowing that TextEdit exists there is greater.

@emilk
Copy link
Owner

emilk commented Apr 21, 2024

Let's make it an option - this should be up to the user to chose

@rustbasic rustbasic closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants