Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips for non-interactive widgets #4291

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Fix tooltips for non-interactive widgets #4291

merged 1 commit into from
Mar 31, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 31, 2024

At least all those above any interactive widget.

I feel there is still more thinking to be done about what is considered hovered and how it relates to contains_pointer, but this PR at least fixes tooltips for uninteractive widgets

@emilk
Consider all non-interactie widgets under the mouse pointer hovered
1c6ff19 
At least all those above any interactive widget.
@emilk emilk added bug Something is broken egui labels Mar 31, 2024
@emilk emilk merged commit bb06bef into master Mar 31, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-tooltips branch March 31, 2024 18:06
emilk added a commit that referenced this pull request Apr 2, 2024
@emilk
Consider all non-interactie widgets under the mouse pointer hovered (#…
0c10daf 
…4291)

At least all those above any interactive widget.

* Closes #4286

I feel there is still more thinking to be done about what is considered
`hovered` and how it relates to `contains_pointer`, but this PR at least
fixes tooltips for uninteractive widgets
emilk added a commit that referenced this pull request Apr 2, 2024
@emilk
Consider all non-interactie widgets under the mouse pointer hovered (#…
40c5088 
…4291)

At least all those above any interactive widget.

* Closes #4286

I feel there is still more thinking to be done about what is considered
`hovered` and how it relates to `contains_pointer`, but this PR at least
fixes tooltips for uninteractive widgets
emilk added a commit that referenced this pull request Apr 2, 2024
@emilk
Consider all non-interactie widgets under the mouse pointer hovered (#…
5549ef8 
…4291)

At least all those above any interactive widget.

* Closes #4286

I feel there is still more thinking to be done about what is considered
`hovered` and how it relates to `contains_pointer`, but this PR at least
fixes tooltips for uninteractive widgets
@emilk emilk changed the title Consider all non-interactie widgets under the mouse pointer hovered Fix tooltips for non-interactive widgets Apr 2, 2024
@emilk emilk mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hover only interactions no longer work
1 participant
@emilk