Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zoom/pan a plot as long as it contains the mouse cursor #4292

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 31, 2024

This is a fix meant mostly for Rerun, where we sometiems paint a vertical time-line over the plot (which is interactive). Before this PR you couldn't zoom or pan the plot while hovering that line, which was really annoying.

This is a fix meant mostly for Rerun, where we sometiems paint a
vertical time-line over the plot (which is interactive).
Before this PR you couldn't zoom or pan the plot while hovering that
line, which was really annoying.
@emilk emilk added bug Something is broken egui_plot Related to egui_plot labels Mar 31, 2024
@emilk emilk merged commit aa2f87e into master Mar 31, 2024
37 checks passed
@emilk emilk deleted the emilk/zoom-pan-plot branch March 31, 2024 18:20
emilk added a commit that referenced this pull request Apr 2, 2024
This is a fix meant mostly for Rerun, where we sometiems paint a
vertical time-line over the plot (which is interactive). Before this PR
you couldn't zoom or pan the plot while hovering that line, which was
really annoying.
emilk added a commit that referenced this pull request Apr 2, 2024
This is a fix meant mostly for Rerun, where we sometiems paint a
vertical time-line over the plot (which is interactive). Before this PR
you couldn't zoom or pan the plot while hovering that line, which was
really annoying.
emilk added a commit that referenced this pull request Apr 2, 2024
This is a fix meant mostly for Rerun, where we sometiems paint a
vertical time-line over the plot (which is interactive). Before this PR
you couldn't zoom or pan the plot while hovering that line, which was
really annoying.
@emilk emilk mentioned this pull request Apr 2, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…4292)

This is a fix meant mostly for Rerun, where we sometiems paint a
vertical time-line over the plot (which is interactive). Before this PR
you couldn't zoom or pan the plot while hovering that line, which was
really annoying.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui_plot Related to egui_plot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant