Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui_plot: Fix the same plot tick label being painted multiple times #4307

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Apr 2, 2024

Usually this isn't visible (the same label being painted on top of itself), but it will be visible if the user has a custom formatter (e.g. y_axis_formatter) that choses a different format based on GridMark:step_size (e.g. using fewer decimals for thicker ticks).

Usually this isn't visible (the same label being painted on top of
itself), but it will be visible if the user has a custom formatter
(e.g. `y_axis_formatter`) that choses a different format based on
`GridMark:step_size` (e.g. using fewer decimals for thicker ticks).
@emilk emilk added bug Something is broken egui_plot Related to egui_plot labels Apr 2, 2024
@emilk emilk merged commit 36ebce1 into master Apr 2, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-plot-tick-overdraw branch April 2, 2024 13:37
emilk added a commit that referenced this pull request Apr 2, 2024
…#4307)

Usually this isn't visible (the same label being painted on top of
itself), but it will be visible if the user has a custom formatter (e.g.
`y_axis_formatter`) that choses a different format based on
`GridMark:step_size` (e.g. using fewer decimals for thicker ticks).
@emilk emilk changed the title egui_plots: Fix the same plot tick label being painted multiple times egui_plot: Fix the same plot tick label being painted multiple times Apr 2, 2024
@emilk emilk mentioned this pull request Apr 2, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
…emilk#4307)

Usually this isn't visible (the same label being painted on top of
itself), but it will be visible if the user has a custom formatter (e.g.
`y_axis_formatter`) that choses a different format based on
`GridMark:step_size` (e.g. using fewer decimals for thicker ticks).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui_plot Related to egui_plot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant