Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: When the program is minimized, the viewport stops working. #4487

Closed
wants to merge 9 commits into from

Conversation

rustbasic
Copy link
Contributor

Fix: When the program is minimized, the viewport stops working.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this thoroughly with test_viewports?

let mut glutin = self.glutin.borrow_mut();
let original_viewport = &glutin.viewports[&viewport_id];

// This will only happens when a Immediate Viewport.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead comment?

return EventResult::Wait;
};

// This will only happens when a Immediate Viewport.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This will only happens when a Immediate Viewport.

@rustbasic
Copy link
Contributor Author

Have you tested this thoroughly with test_viewports?

Yes, I tested it for a long time on Windows 10

@rustbasic rustbasic requested a review from emilk May 21, 2024 11:48
@rustbasic rustbasic closed this Jul 11, 2024
@rustbasic rustbasic deleted the patch54 branch August 7, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the program is minimized, the viewport stops working.
2 participants