Use Arc instead of Vec for cheaper PlotPoints clone #4562
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it cheaper to create Line Plots. On each pass, I noticed that the PlotPoints::new interface used to copy 10s-100s of MiB, when we could be doing a cheap
Arc<[PlotPoint]>
clone instead of an expensiveVec<PlotPoint>
clone.It is related to emilk/egui_plot#18, but as discussion has referenced, there are several aspects degrading rendering performance and this is not a silver bullet.
Construction is slightly different
Usage looks identical.
If ExplicitGenerator were Clone, then we would be able to have PlotPoints be Clone.