GIF support #4620
Merged
GIF support #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could add |
YgorSouza
reviewed
Jun 6, 2024
emilk
reviewed
Jun 6, 2024
|
@emilk every requested change is implemented. I didn't test the file_loader, but it should behave the exactly like the ehttp loader which works. |
emilk
requested changes
Jun 7, 2024
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
|
@emilk ?? |
emilk
reviewed
Jun 18, 2024
|
btw, as I mention in the PR template, opening a PR from your |
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
|
@emilk Im sorry. I will keep that in mind for the next pull request |
emilk
approved these changes
Jun 19, 2024
emilk
approved these changes
Jun 19, 2024
| @@ -27,6 +27,7 @@ impl eframe::App for MyApp { | |||
| fn update(&mut self, ctx: &egui::Context, _frame: &mut eframe::Frame) { | |||
| egui::CentralPanel::default().show(ctx, |ui| { | |||
| egui::ScrollArea::both().show(ui, |ui| { | |||
| ui.image(egui::include_image!("ferris.gif")); | |||
There was a problem hiding this comment.
It's super cool that this Just Works™️
|
should be ready to merge now |
|
Thanks for going through all the review rounds on this! |
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
egui_extrasyou need to add thegiffeature flag to it. Then adding a .gif to egui is as easy as