Add PopupCloseBehavior
#4636
Merged
Add PopupCloseBehavior
#4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PopupCloseBehavior` determines when popup will be closed. - `CloseOnClick` popup will be closed if the click happens anywhere even in the popup's body - `CloseOnClickAway` popup will be closed if the click happens somewhere else but in the popup's body.
emilk
requested changes
Jun 18, 2024
crates/egui/src/containers/popup.rs
Outdated
Comment on lines
259
to
260
| /// Popup will be closed on click | ||
| /// It is used in the [`ComboBox`] |
There was a problem hiding this comment.
Suggested change
| /// Popup will be closed on click | |
| /// It is used in the [`ComboBox`] | |
| /// Popup will be closed on click anywhere, inside or outside the popup. | |
| /// | |
| /// It is used in [`ComboBox`]. |
crates/egui/src/containers/popup.rs
Outdated
|
|
||
| /// Popup will be closed if the click happened somewhere else | ||
| /// but in the popup's body | ||
| CloseOnClickAway, |
There was a problem hiding this comment.
Suggested change
| CloseOnClickAway, | |
| CloseOnClickOutside, |
crates/egui/src/containers/popup.rs
Outdated
| .inner; | ||
| }); | ||
|
|
||
| let is_close = match close_behavior { |
There was a problem hiding this comment.
Suggested change
| let is_close = match close_behavior { | |
| let should_close = match close_behavior { |
("is close" sounds like it is about proximity)
emilk
approved these changes
Jun 26, 2024
|
CI is red though |
|
@emilk I fixed the doc test so now everything should be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
PopupCloseBehaviorto improve state of the #4607PopupCloseBehaviordetermines when popup will be closed.CloseOnClickpopup will be closed if the click happens anywhere even in the popup's bodyCloseOnClickAwaypopup will be closed if the click happens somewhere else but in the popup's body.It also adds a test in the demo app which contains several popups examples.
My ideas about #4607 is to make every tooltip and popup a menu. So it will provide more control over popups and tooltips (you will be able to close a popup by calling something similar to the
ui.close_menuif you need to). You won't need to manually handle it's opening. And also will allow to have multiple popups opened. That means you can have a popup inside a popup. And it will also lead to the easier creation of the popups. (should we create a tracking issue to track changes because to me it seems like a huge amount of changes to be done?)