Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the IME event first in TextEdit to fix some bugs #4794

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Handle the IME event first in TextEdit to fix some bugs #4794

merged 2 commits into from
Jul 7, 2024

Conversation

rustbasic
Copy link
Contributor

Handle the IME event first
There is a need to handle the Ime event first.

Fix Issues : When you press BackSpace, the entire text is erased, and when you press another letter, it appears again.
Fix Issues : When you press Left, the character being entered will be copied once more.
Fix Issues : When you press Enter, Enter with repeat set is entered and Enter is entered twice.
Fix Issues : When you press a key in IME mode, repeat is often set.

Fix Issues : Since you may be selecting something in the IME, this also disables the Arrow keys.

emilk
emilk requested changes Jul 7, 2024
View reviewed changes
crates/egui/src/widgets/text_edit/builder.rs Outdated Show resolved Hide resolved
crates/egui/src/widgets/text_edit/builder.rs Outdated Show resolved Hide resolved
@rustbasic rustbasic requested a review from emilk July 7, 2024 07:23
@emilk emilk changed the title Handle the IME event first Handle the IME event first in TextEdit to fix some bugs Jul 7, 2024
@emilk emilk changed the title Handle the IME event first in TextEdit to fix some bugs Handle the IME event first in TextEdit to fix some bugs Jul 7, 2024
@emilk emilk added bug Something is broken egui IME labels Jul 7, 2024
@emilk emilk merged commit fcd02bd into emilk:master Jul 7, 2024
21 of 22 checks passed
This was referenced Aug 1, 2024
Merged
Closed
Merged
emilk pushed a commit that referenced this pull request Aug 5, 2024
@rustbasic
Fix: Backspace not working after IME input (#4912)
76fe6c8 
Fix: Changed the handling method of `Ime::Preedit(_, None)`

Fix: backspace fail after ime input

* Related #4358
* Related #4430 
* Related #4436
* Related #4794 
* Related #4896
* Closes #4908 

Issues: backspace fail after ime input
* #4908 (Chinese)

Changed the handling method of `Ime::Preedit(_, None)`
@rustbasic rustbasic mentioned this pull request Aug 27, 2024
Closed
emilk pushed a commit that referenced this pull request Aug 28, 2024
@rustbasic
Fix: Ensures correct IME behavior when the text input area gains or l…
8e5492b 
…oses focus. (#4896)

Fix: Ensures correct IME behavior when the text input area gains or
loses focus.

Fix: Handling `state.ime_enabled` in multiple `TextEdit`.
Fix: A symptom of characters being copied when there are multiple
TextEdits.

* Related #4137
* Related #4358 
* Closes #4374
* Related #4436
* Related #4794 
* Related #4908 

* Related #5008

Fix Issues: When focus is moved elsewhere, you must set
`state.ime_enabled = false`, otherwise the IME will have problems when
focus returns.

Fix Issues: A symptom of characters being copied when there are multiple
TextEdits.
Deletes all current `IME events`, preventing them from being copied to
`other TextEdits`, without saving the `TextEdit ID`,

( Related Issues: Some `LINUX` seem to trigger an IME enable event on
startup. So, when we gained focus, we do `state.ime_enabled = false`. )
rib pushed a commit to EmbarkStudios/egui that referenced this pull request Sep 30, 2024
@rustbasic @rib
Fix: Backspace not working after IME input (emilk#4912)
d281d93 
Fix: Changed the handling method of `Ime::Preedit(_, None)`

Fix: backspace fail after ime input

* Related emilk#4358
* Related emilk#4430 
* Related emilk#4436
* Related emilk#4794 
* Related emilk#4896
* Closes emilk#4908 

Issues: backspace fail after ime input
* emilk#4908 (Chinese)

Changed the handling method of `Ime::Preedit(_, None)`
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@rustbasic @486c
Handle the IME event first in TextEdit to fix some bugs (emilk#4794)
27fb898 
Handle the `IME` event first 
There is a need to handle the Ime event first.

Fix Issues : When you press `BackSpace`, the entire text is erased, and
when you press another letter, it appears again.
Fix Issues : When you press `Left`, the character being entered will be
copied once more.
Fix Issues : When you press `Enter`, `Enter` with `repeat` set is
entered and `Enter` is entered twice.
Fix Issues : When you press a key in `IME` mode, `repeat` is often set.

Fix Issues : Since you may be selecting something in the IME, this also
disables the `Arrow` keys.
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@rustbasic @486c
Fix: Backspace not working after IME input (emilk#4912)
ecda6d3 
Fix: Changed the handling method of `Ime::Preedit(_, None)`

Fix: backspace fail after ime input

* Related emilk#4358
* Related emilk#4430 
* Related emilk#4436
* Related emilk#4794 
* Related emilk#4896
* Closes emilk#4908 

Issues: backspace fail after ime input
* emilk#4908 (Chinese)

Changed the handling method of `Ime::Preedit(_, None)`
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@rustbasic @486c
Fix: Ensures correct IME behavior when the text input area gains or l…
a72081b 
…oses focus. (emilk#4896)

Fix: Ensures correct IME behavior when the text input area gains or
loses focus.

Fix: Handling `state.ime_enabled` in multiple `TextEdit`.
Fix: A symptom of characters being copied when there are multiple
TextEdits.

* Related emilk#4137
* Related emilk#4358 
* Closes emilk#4374
* Related emilk#4436
* Related emilk#4794 
* Related emilk#4908 

* Related emilk#5008

Fix Issues: When focus is moved elsewhere, you must set
`state.ime_enabled = false`, otherwise the IME will have problems when
focus returns.

Fix Issues: A symptom of characters being copied when there are multiple
TextEdits.
Deletes all current `IME events`, preventing them from being copied to
`other TextEdits`, without saving the `TextEdit ID`,

( Related Issues: Some `LINUX` seem to trigger an IME enable event on
startup. So, when we gained focus, we do `state.ime_enabled = false`. )
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@rustbasic @hacknus
Handle the IME event first in TextEdit to fix some bugs (emilk#4794)
08aacd3 
Handle the `IME` event first 
There is a need to handle the Ime event first.

Fix Issues : When you press `BackSpace`, the entire text is erased, and
when you press another letter, it appears again.
Fix Issues : When you press `Left`, the character being entered will be
copied once more.
Fix Issues : When you press `Enter`, `Enter` with `repeat` set is
entered and `Enter` is entered twice.
Fix Issues : When you press a key in `IME` mode, `repeat` is often set.

Fix Issues : Since you may be selecting something in the IME, this also
disables the `Arrow` keys.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@rustbasic @hacknus
Fix: Backspace not working after IME input (emilk#4912)
8f69ccc 
Fix: Changed the handling method of `Ime::Preedit(_, None)`

Fix: backspace fail after ime input

* Related emilk#4358
* Related emilk#4430 
* Related emilk#4436
* Related emilk#4794 
* Related emilk#4896
* Closes emilk#4908 

Issues: backspace fail after ime input
* emilk#4908 (Chinese)

Changed the handling method of `Ime::Preedit(_, None)`
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@rustbasic @hacknus
Fix: Ensures correct IME behavior when the text input area gains or l…
7d20999 
…oses focus. (emilk#4896)

Fix: Ensures correct IME behavior when the text input area gains or
loses focus.

Fix: Handling `state.ime_enabled` in multiple `TextEdit`.
Fix: A symptom of characters being copied when there are multiple
TextEdits.

* Related emilk#4137
* Related emilk#4358 
* Closes emilk#4374
* Related emilk#4436
* Related emilk#4794 
* Related emilk#4908 

* Related emilk#5008

Fix Issues: When focus is moved elsewhere, you must set
`state.ime_enabled = false`, otherwise the IME will have problems when
focus returns.

Fix Issues: A symptom of characters being copied when there are multiple
TextEdits.
Deletes all current `IME events`, preventing them from being copied to
`other TextEdits`, without saving the `TextEdit ID`,

( Related Issues: Some `LINUX` seem to trigger an IME enable event on
startup. So, when we gained focus, we do `state.ime_enabled = false`. )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui IME
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustbasic @emilk