Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS build, and add iOS step to CI #4898

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

lucasmerlin
Copy link
Collaborator

@lucasmerlin lucasmerlin commented Aug 1, 2024

This PR

  • adds a pipeline to check the ios build
  • removes the iOS WaitUntil workaround, which doesn't seem to be necessary anymore after the winit update (and caused the build for iOS to fail again because of a missing self
  • removes a iOS workaround for window size which doesn't seem necessary anymore
    Turns out it was still needed (but you need to actually restart the app for the issue to show up, so I didn't catch it first)
  • fixes some cargo check errors in run.rs

I've done all these changes in a single PR because otherwise the pipeline doesn't run but I can also split them in separate PRs if that makes it easier to review

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, but CI is red

@emilk emilk added CI Continues Integration test iOS labels Aug 5, 2024
@lucasmerlin
Copy link
Collaborator Author

@emilk finally got around to fixing the lint warnings, sorry it took so long

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk changed the title Add ios pipeline Fix iOS build, and add iOS step to CI Aug 26, 2024
@emilk emilk added the eframe Relates to epi and eframe label Aug 26, 2024
@emilk emilk merged commit c9e00e5 into emilk:master Aug 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continues Integration test eframe Relates to epi and eframe iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants