Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin & upgrade winit to 0.30.5 #4939

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

ArthurBrussee
Copy link
Contributor

This updates winit to 0.30.5.

#4849 Had to pin the version to 0.30.2, as a Winit patch changed the behavior of selecting a theme. Winit 0.30.5 reverts this, so we could stick with window.theme(), but the newly added ActiveEventLoop::system_theme is more like what egui wants anyway, as individual windows can have theme overrides.

Also bump smithay-clipboard to prevent some now duplicate dependencies.

@girtsf
Copy link
Contributor

girtsf commented Aug 8, 2024

Tested and can confirm that this fixes touchscreen release issues (#4895).

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@emilk emilk added eframe Relates to epi and eframe egui-winit porblems related to winit dependencies Pull requests that update a dependency file labels Aug 9, 2024
@emilk emilk merged commit 1f6ae49 into emilk:master Aug 9, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe egui-winit porblems related to winit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

touchscreen click events are not detected properly (on Linux)
3 participants